-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1093 by moving requirements into environment.yml #1094
Conversation
Current coverage is 98.79% (diff: 100%)@@ master #1094 diff @@
==========================================
Files 38 38
Lines 2830 2830
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2796 2796
Misses 34 34
Partials 0 0
|
Ah, I see you did remove the requirements.txt. Ok, very good. Let's try it this way and see what breaks. I think the only possible issue will be what happens when I try to upload a new release to PyPI (https://pypi.python.org/pypi/taxcalc). If this breaks, I will find a way to fix it that does not involve creating a requirements.txt, since that eventually leads to dependencies specified in two places, which is bad. |
I would really appreciate that. I have no idea how the environment is created when this is built as a package. I imagine it has something to do with this line in
The Travis environment doesn't use
It would be awesome if we could unify the environments for local users, package users, and testing at some point. |
83e97d2
to
cccca19
Compare
Just pushed a quick fix - the |
@talumbau, could you merge this if it looks good to you? |
looks good. merging. |
To fix #1093:
pandas
andnumpy
lines inrequirements.txt
.numba == 0.26.0
also implicity declaresnumpy>=1.7
. Numba was also in theenvironment.yml
, but without a version constraint, so I moved this there.six
andtoolz
were declared in both places, so I removed themThat made
requirements.txt
empty, so I removed it. Happy to keep it in if preferred!