Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c03260 to _expanded_income and fix handling of c03260 haircut #1032

Merged
merged 3 commits into from
Nov 4, 2016
Merged

Add c03260 to _expanded_income and fix handling of c03260 haircut #1032

merged 3 commits into from
Nov 4, 2016

Conversation

martinholmer
Copy link
Collaborator

This pull request adds the self-employment tax deduction from AGI, which is represented by the c03260 variable, into the _expanded_income variable. So, now c03260 is treated in the ExpandIncome function exactly the same as the portion of social security benefits not in AGI is treated.

In the course of reviewing c03260 logic, a bug became apparent: the _ALD_SelfEmploymentTax_HC parameter was not being used in the calculation of the _earned_p and _earned_s variables even though it was being used in the calculation of the _earned variable. Because the _earned_p and earned_s variables are used only in Form 2441, the effect of this bug fix was limited in scope and small in magnitude.

This pull request causes a small change in reform comparison results for one reform that completely eliminates the AGI deduction for half of the self-employment tax; all other 50+ reform comparisons are the same as before. There are no changes in unit test results or in validation test results.

@MattHJensen @feenberg @Amy-Xu @GoFroggyRun @andersonfrailey @codykallen

@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 98.48% (diff: 100%)

Merging #1032 into master will not change coverage

@@             master      #1032   diff @@
==========================================
  Files            35         35          
  Lines          2243       2243          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2209       2209          
  Misses           34         34          
  Partials          0          0          

Powered by Codecov. Last update a21bb94...5bf832c

@martinholmer martinholmer merged commit fcb95a1 into PSLmodels:master Nov 4, 2016
@martinholmer martinholmer deleted the fix-exp-inc branch November 6, 2016 23:11
@martinholmer martinholmer mentioned this pull request Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants