Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded income and aftertax income should be options in distribution tables #1374

Closed
MattHJensen opened this issue May 19, 2017 · 12 comments
Closed
Assignees

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented May 19, 2017

image

Users may want to see average expanded income by expanded income bin or decile in TaxBrain diagnostic tables. Same with aftertax income.

@MattHJensen MattHJensen changed the title Expanded income should be an option in our tables Expanded income and aftertax income should be options in diagnostic tables May 23, 2017
@martinholmer
Copy link
Collaborator

I've looked into Tax-Calculator issue #1374, which says:

Users may want to see average expanded income by expanded income bin or decile in TaxBrain diagnostic tables. Same with aftertax income.

The construction in dropq code of a TaxBrain "diagnostic" table (which is called in Tax-Calculator a "distribution" table) is fairly involved. The data structures that are created by the dropq code have been carefully designed to meet the needs of TaxBrain developers, which is exactly as it should be.

My conclusion is that the TaxBrain developers need to start out this enhancement process by specifying exactly how they want the thirteen objects returned from the dropq.run_nth_year_tax_calc_model function to be changed in order to implement the #1374 enhancement. Then, with this change specification in hand, Tax-Calculator developers can revise taxcalc code to supply revised versions of those thirteen objects.

Does this approach make sense?

@MattHJensen @feenberg @Amy-Xu @GoFroggyRun @PeterDSteinberg @brittainhard

@feenberg
Copy link
Contributor

feenberg commented Jun 28, 2017 via email

@martinholmer
Copy link
Collaborator

Dan @feenberg said with respect to issue #1374:

The important thing is that we drop 3 meaningful records from each row returned to the user. So if we tab[ulate] by expanded income we drop 3 records from each expanded income class, not each AGI class.

As far as I can tell, TaxBrain never shows distributional tables with AGI bins; it shows only distributional tables with expanded-income bins. And the dropq code does remove three records from each expanded-income bin. So, I think your concerns are being met.

@MattHJensen @PeterDSteinberg @brittainhard

@martinholmer martinholmer changed the title Expanded income and aftertax income should be options in diagnostic tables Expanded income and aftertax income should be options in distribution tables Sep 6, 2017
@martinholmer
Copy link
Collaborator

I've moved a question about the Brown-Khanna GAIN Act that was submitted in this issue to its own issue #1581.

@PSLmodels PSLmodels deleted a comment from travelmail26 Oct 9, 2017
@martinholmer
Copy link
Collaborator

martinholmer commented Oct 19, 2017

@MattHJensen said in issue #1374:

Users may want to see average expanded income by ... bin or decile in TaxBrain diagnostic tables. Same with aftertax income.

The current TaxBrain version (1.0.3) allows users to build a "Distribution Table" or a "Difference Table".

So, is your request to add to the Distribution Table two new columns: average expanded income and average after-tax expanded income?

Does it make sense to add these two new columns to the Difference Table as well?
I'm asking this because the 10/17 New York Times graphs are difference tables with decile bins as seen in this example:

screen shot 2017-10-19 at 12 38 48 pm

@MattHJensen
Copy link
Contributor Author

@martinholmer asked two questions:

So, is your request to add to the Distribution Table two new columns: average expanded income and average after-tax expanded income?

Does it make sense to add these two new columns to the Difference Table as well?

Yes to both.

@martinholmer
Copy link
Collaborator

martinholmer commented Oct 19, 2017

Is the labeling of the income groups in this New York Times (10/17/2017) graph slightly incorrect?

screen shot 2017-10-19 at 12 38 48 pm

Shouldn't the left-hand column read like this?

99 ("top 1%")
95-98
90-94
80-89
70-79
60-69
50-59
40-49
30-39
20-29
10-19
0-9

As it appears in the newspaper, there are 101 percentiles (not 100).

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun

@MattHJensen
Copy link
Contributor Author

MattHJensen commented Oct 19, 2017

I don't think it is incorrect. It looks like they are doing (x-y] and therefore starting with 1 instead of 0.

@martinholmer
Copy link
Collaborator

@MattHJensen said:

I don't think it is incorrect per se. It looks like they are doing (x-y] and therefore starting with 1 instead of 0.

I guess numbers in the left-hand column supposed to be quantiles that are the boundaries of the percentiles. Does that make sense?

@martinholmer martinholmer self-assigned this Oct 19, 2017
@MattHJensen
Copy link
Contributor Author

I guess numbers in the left-hand column supposed to be quantiles that are the boundaries of the percentiles. Does that make sense?

Yep, that's what I'm thinking. The left-hand column is a an exclusive boundary, and the right-hand column is an inclusive boundary.

@MattHJensen
Copy link
Contributor Author

It lines up better with the way people talk about the top 1% and bottom 99%, I suppose.

@martinholmer
Copy link
Collaborator

Issue #1374 has been resolved by merge of #1602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants