Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.5 #1364

Closed
MattHJensen opened this issue May 12, 2017 · 6 comments
Closed

Release 0.8.5 #1364

MattHJensen opened this issue May 12, 2017 · 6 comments

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented May 12, 2017

After your pull requests are merged to master, please edit the 0.8.5 section of the release history and submit those edits as a pull request.

The last commit in 0.8.4 was 344e39f, which was the merge of #1363 on May 12, 2017.

@martinholmer
Copy link
Collaborator

martinholmer commented Jun 6, 2017

Documentation of #1375 and #1376 has been moved from issue #1364 to the release history contained in the tax-calculator/RELEASES.md file.

@MattHJensen
Copy link
Contributor Author

@martinholmer, thanks a lot for the tax-calculator/RELEASES.md file.

Having that file is definitely valuable, and I see two paths for using it:

  1. Continue documenting the releases at https://github.com/open-source-economics/Tax-Calculator/releases, and use RELEASES.md as a substitute for the github issues that we were filling out before (like this one, Release 0.8.5 #1364).

  2. Use RELEASES.md as a substitute for both https://github.com/open-source-economics/Tax-Calculator/releases and the github issues.

If we go with (1), I don’t think it is necessary to link to the PRs in RELEASES.md, those links will be available from the GH releases interface

If we go with (2), I think it would also be helpful in RELEASES.md to include a link to the last commit in the release as well as the links to the PRs.

The main advantage of (1) is that adding the links to PRs and last commit could be a minor inconvenience.

The main advantage of (2) is that we don’t have duplicated information in RELEASES.md and the GH releases interface.

@martinholmer
Copy link
Collaborator

@MattHJensen said:

thanks a lot for the tax-calculator/RELEASES.md file.

Having that file is definitely valuable, and I see two paths for using it:

  1. Continue documenting the releases at https://github.com/open-source-economics/Tax-Calculator/releases, and use RELEASES.md as a substitute for the github issues that we were filling out before (like this one, Release 0.8.5 #1364).

  2. Use RELEASES.md as a substitute for both https://github.com/open-source-economics/Tax-Calculator/releases and the github issues.

If we go with (1), I don’t think it is necessary to link to the PRs in RELEASES.md, those links will be available from the GH releases interface

If we go with (2), I think it would also be helpful in RELEASES.md to include a link to the last commit in the release as well as the links to the PRs.

The main advantage of (1) is that adding the links to PRs and last commit could be a minor inconvenience.

The main advantage of (2) is that we don’t have duplicated information in RELEASES.md and the GH releases interface.

Seems like (2) is the better option. So, I guess, you can create a release on GitHub without added the comment with description. Is that correct?

I'd be happy to add in RELEASES.md a link to the last commit in each release. Let me know if and when you want me to do that.

@MattHJensen
Copy link
Contributor Author

Seems like (2) is the better option. So, I guess, you can create a release on GitHub without added the comment with description. Is that correct?

That is correct. I'll just include a link to RELEASES.md

I'd be happy to add in RELEASES.md a link to the last commit in each release. Let me know if and when you want me to do that.

That'd be great. Thanks!

@MattHJensen
Copy link
Contributor Author

I hope to release 0.8.5 today, or as soon as we merge #1385.

@MattHJensen
Copy link
Contributor Author

Release
Changelog

Thanks @andersonfrailey, @martinholmer, and @hdoupe for contributions to 0.8.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants