Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for eta_RM parameter #126

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Conversation

jdebacker
Copy link
Member

OG-Core version 0.13.0 added new parameters for modeling remittances. One of these, eta_RM distributes remittences by age and ability and is represented by an SxJ matrix. Since the default value of J differs in OG-USA than the default parameters for OG-Core, OG-USA needs to specific a conforming eta_RM matrix in its default calibration. This PR specifies a value of eta_RM for OG-USA.

Note that this parameter has no effect on OG-USA since the default amount of remittances in the model is 0.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.22%. Comparing base (605017e) to head (d4934ed).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   45.22%   45.22%           
=======================================
  Files          18       18           
  Lines        1404     1404           
=======================================
  Hits          635      635           
  Misses        769      769           
Flag Coverage Δ
unittests 45.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogusa/__init__.py 100.00% <100.00%> (ø)

@jdebacker jdebacker merged commit 5104eed into PSLmodels:master Oct 5, 2024
8 checks passed
@jdebacker jdebacker deleted the etaRM branch October 5, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants