Fix bug in run_og_usa.py
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 45.22% 45.22%
=======================================
Files 18 18
Lines 1404 1404
=======================================
Hits 635 635
Misses 769 769
Flags with carried forward coverage won't be shown. Click here to find out more. |
rickecon
approved these changes
Oct 3, 2024
|
@jdebacker. This PR looks ready to go. Is this ready for merge? I don't know how I've missed this one from nearly a month ago. |
|
@rickecon yes, this is easy to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the example script,
run_og_usa.pythat was introduced in PR #122. The error was not updating thebaselineandoutput_baseparameters for the reform run, which mean that the reform run was saved over the baseline run.