Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the baseline_spending=True parameterization #957

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

jdebacker
Copy link
Member

In PR #880, all TPI output arrays were cast as have a length of T in the time dimension.

This posed an error for the case of baseline_spending=True, which was looking for aggregate transfers (TR) to be of length T+S. This PR fixes that error.

@jdebacker jdebacker added the bug label Aug 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.31%. Comparing base (19c90fc) to head (64d690c).

Files Patch % Lines
ogcore/TPI.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   71.29%   71.31%   +0.01%     
==========================================
  Files          20       20              
  Lines        4954     4953       -1     
==========================================
  Hits         3532     3532              
+ Misses       1422     1421       -1     
Flag Coverage Δ
unittests 71.31% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/TPI.py 35.82% <0.00%> (+0.09%) ⬆️

@rickecon
Copy link
Member

rickecon commented Aug 5, 2024

@jdebacker. This looks great. Now passed all tests. Merging now.

@rickecon rickecon merged commit e799452 into PSLmodels:master Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants