Extrapolating nested lists #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 71.92% 71.97% +0.05%
==========================================
Files 19 19
Lines 4723 4732 +9
==========================================
+ Hits 3397 3406 +9
Misses 1326 1326
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rickecon
approved these changes
Jul 26, 2024
|
@jdebacker. This looks good to me. Let me know if this is ready to merge. |
|
This is ready to merge. @rickecon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the functionality used to extended the nested lists of tax parameters. New tests are added to ensure it creates lists of the expected sizes.