-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to txfunc.py
#932
Updates to txfunc.py
#932
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 72.76% 72.44% -0.32%
==========================================
Files 19 19
Lines 4644 4696 +52
==========================================
+ Hits 3379 3402 +23
- Misses 1265 1294 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Currently tests pass on Mac OS, fail on Linux (not yet run on Windows). Test failure is with the SSE from the regressions for the HSV functions. These are computed via simple matrix operations and thus I'm surprised there is any difference across platforms. @rickecon Any ideas why dot products would not be identical across platforms? |
@rickecon This PR is ready for your review. The changes to starting values (which apply to the GS and DEP functions only) are to estimate the specified tax functions for all ages via a global optimizer (in this case, |
@jdebacker. The Linux/Python 3.10 test seems to be stalled out. I wonder what is going on with the tests. I am just waiting for these all to pass. I approved all the code changes. |
@jdebacker. This looks great and all checks have passed. Merging. |
This PR will make the following changes: