Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove ACF migration blocks #207

Merged
merged 1 commit into from
Jul 15, 2024
Merged

WIP: Remove ACF migration blocks #207

merged 1 commit into from
Jul 15, 2024

Conversation

gtenaschuk
Copy link
Collaborator

  • Remove ACF Groups for Migration fields not being used anymore.

@rpeterman-gp
Copy link
Contributor

rpeterman-gp commented May 2, 2024

@gtenaschuk Is removing the files supposed to remove the field groups from the admin? I am still seeing them even after a sync. Do we have to manually remove them via the admin as well?

@gtenaschuk
Copy link
Collaborator Author

Hey @rpeterman-gp sorry for my late reply here.
Yes, i forgot to mention that i would wait for the deploy to delete them in the database.
When you have a group in the database but does not have a JSON file stored in the filesystem you will see the groups with the status "Awainting save". Like in the image attached, that happens because i removed the field from the git repo.
Captura de pantalla 2024-05-03 a la(s) 12 06 02

@rpeterman-gp
Copy link
Contributor

@gtenaschuk Will removing the fields from the database also remove the meta data records for them? We still rely on some of these fields, such as the media original_uri meta data.

@gtenaschuk
Copy link
Collaborator Author

Hey @rpeterman-gp no, they are not going to delete the meta data.
For that we will run these queries when the code is in live and no more fields will be available to store data in the database.
https://docs.google.com/document/d/1_xJZBj9iSNsS7VcukuJS5gOUph_AboVPUk5NXABNpbM/edit

@gtenaschuk
Copy link
Collaborator Author

We are going to work on other post types next week, because Episodes need more attention since we are using migrated fields in other groups using the same meta key and we need to keep them in the db.

@brandonhundt brandonhundt changed the title Remove ACF migration blocks WIP: Remove ACF migration blocks May 16, 2024
@brandonhundt brandonhundt removed their request for review June 5, 2024 14:45
Copy link
Contributor

@rpeterman-gp rpeterman-gp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets's go! :shipit:

@gtenaschuk gtenaschuk merged commit 9a7ce33 into main Jul 15, 2024
@gtenaschuk gtenaschuk deleted the acf_blocks_clean branch July 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants