Issue310 faster makefiles #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks bisect for now
surrounds in ifdef and also lazily evaluates REC_MAKE variable so that someone could add to that variable.
This is to always be defined and can be used from Makefile_bisect_binary.in
Targets that are working: - trouble - trouble-out - trouble-fpic - <bisect-dir>/gtrun-lib Targets that kind of work: - bisect-smallclean - bisect-clean - bisect-distclean Targets that are still broken: - bisect
Also for Makefile_bisect_binary.in Done by marking recursive targets as PHONY
The problem was having -fno-pie specified after -fPIC. To fix it, I needed to have -fPIC specified after.
mikebentley15
added
enhancement
python
IanBriggs
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
Note: pull request #309 should be approved first since this one builds upon it.
Description:
Redesign the Makefile and Bisect Makefile to use more recursion to make them more responsive.
Documentation:
None. Same behavior, just more responsive.
Tests:
Updated some tests and made sure each test passes correctly.