Issue276 silent color makefiles #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be reversed by using any value inside of VERBOSE (e.g., make[1]: Entering directory '/home/bentley/git/FLiT/tests/flit_cli' make[2]: Entering directory '/home/bentley/git/FLiT/tests/flit_cli/flit_import' make[2]: Nothing to be done for 'build'. make[2]: Leaving directory '/home/bentley/git/FLiT/tests/flit_cli/flit_import' make[2]: Entering directory '/home/bentley/git/FLiT/tests/flit_cli/flit_version' make[2]: Nothing to be done for 'build'. make[2]: Leaving directory '/home/bentley/git/FLiT/tests/flit_cli/flit_version' make[2]: Entering directory '/home/bentley/git/FLiT/tests/flit_cli/flit_update' make[2]: Nothing to be done for 'build'. make[2]: Leaving directory '/home/bentley/git/FLiT/tests/flit_cli/flit_update' make[2]: Entering directory '/home/bentley/git/FLiT/tests/flit_cli/flit_bisect' make[2]: Nothing to be done for 'build'. make[2]: Leaving directory '/home/bentley/git/FLiT/tests/flit_cli/flit_bisect' make[1]: Leaving directory '/home/bentley/git/FLiT/tests/flit_cli' make[1]: Entering directory '/home/bentley/git/FLiT/tests/flit_makefile' make[1]: Nothing to be done for 'build'. make[1]: Leaving directory '/home/bentley/git/FLiT/tests/flit_makefile' make[1]: Entering directory '/home/bentley/git/FLiT/tests/flit_mpi' make[1]: Nothing to be done for 'build'. make[1]: Leaving directory '/home/bentley/git/FLiT/tests/flit_mpi' make[1]: Entering directory '/home/bentley/git/FLiT/tests/harness' make[1]: Nothing to be done for 'build'. make[1]: Leaving directory '/home/bentley/git/FLiT/tests/harness' make[1]: Entering directory '/home/bentley/git/FLiT/tests/flit_src' make[1]: Nothing to be done for 'build'. make[1]: Leaving directory '/home/bentley/git/FLiT/tests/flit_src' make[1]: Entering directory '/home/bentley/git/FLiT/tests/flit_install' make[1]: Nothing to be done for 'build'. make[1]: Leaving directory '/home/bentley/git/FLiT/tests/flit_install'). Done using the .SILENT special target.
mikebentley15
added
enhancement
make
IanBriggs
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Description:
The
Makefileoutput from both autogeneratedMakefiles and the FLiTMakefileare a bit too verbose in my opinion. So, I created brief colored output by default. The full command can still be printed withmake VERBOSE=1 ....Documentation:
Updated various locations in the documentation to specify the
VERBOSE=1flag if details are desired.Tests:
I did not add any new tests. Instead, I changed existing tests to function with this new functionality. For many of the tests, this meant adding
VERBOSE=1to the test (as well as emptying outMAKEFLAGSsince the tests are called from a silent invocation ofmake).