Issue49 return vectors #271

mikebentley15 · 2019-06-10T18:09:05Z

Fixes #49

Description:
You can now return std::vector<float>, std::vector<double>, and std::vector<long double> from tests.

I added those three value types to flit::Variant
Added toString() to flit::Variant which is now how it is output to file in flit::TestBase
Added fromString() to flit::Variant which is now how it is read from file in flit::TestBase

Documentation:
Oops, I did not yet update the documentation.

Tests:

Added tests/flit_src/tst_TestBase.cpp
Added tests/flit_src/tst_Variant.cpp
Copied tests/tinydir.h to do directory listings
Added tests/fsutil.h with tests/harness/tst_fsutil.cpp
Updated other tests to pass

I probably need to add a few more tests

Variant(string) with challenging strings
Not all functionality in fsutils.h are tested

The fixes are problems found by the unit tests

All types except for LongDouble and None. This will now include the vector types. A biproduct of this change is that strings will be different in the files than before, they will not be verbatim in the file, but rather will be Variant("...").

This is based on the value in the results file. The fromString() method is used here to generate a Variant() from the file. The file is populated using the toString() method from Variant(), so it simply is required that they are inverses of each other.

--help: show help documentation --verbose: show verbose information --quiet: don't print anything --list-tests: only list test names

Not yet done though

Also add empty tests for fsutils.cpp

It worked before, but only because each test executable is made up of only one compilation unit, otherwise we may otherwise get a duplicate item error if more than one compilation unit would make up a test executable.

For std::runtime_error to be thrown

I tried to move to GCC 4.9 in Travis-CI, but with difficulty. So, I instead found workarounds for using GCC 4.8.4

Added mkdir(), rmdir(), chdir(), and curdir().

mikebentley15 · 2019-06-11T04:12:38Z

Looks like I still need to

update documentation
make more difficult tests for Variant(std::string)
implement Variant(std::vector<std::string>)

mikebentley15 · 2019-06-11T18:30:12Z

@IanBriggs I have completed all changes I wanted to do.

so much testing -- it should be more than sufficient
std::vector<std::string> can now be returned from a test
I used the string(len=..., val="...") format for encoding a single string, then I can easily do a vector of them. Before, I was assuming that the end of the string with "), and I was taking everything between the beginning " and that ending. Now it is more complicated, and more extendable.
documentation has been updated to reflect these changes (surprisingly only a little documentation for such a big internal change).

Please review at your earliest convenience. This might be useful for our tutorial.

mikebentley15

I've finished my review of my own work, Ian. Please take a look. I found some things I want to change anyway, but please see if there are things I missed or things that could have been done better.

Thank you!

.travis.yml

src/Variant.cpp

src/Variant.h

src/flit.h

tests/tinydir.h

tests/fsutil.h

IanBriggs

Thanks for adding abs to the empty test.
Looks good to me.

mikebentley15 added 30 commits May 30, 2019 15:17

Variant: add vector of float, double, and long double

ea2d9f6

Variant: add unit tests and fixes

fa29615

The fixes are problems found by the unit tests

tests/.gitignore: ignore tst_Variant executable

fc245e7

Variant: add toString()

c7b4d20

Variant: add test for toString() and val<>()

e0db84e

Variant: organize the class implementation

723b11f

Variant: add fromString() method and test

817b13c

TestBase: Add compare() method for vector<T>

066108b

tests: add test for l2norm()

2660db5

Variant: add error path tests

aa61368

Add some tests for TestBase.cpp, but not all

3d4a461

test_harness.h: add command-line options

d7fc472

--help: show help documentation --verbose: show verbose information --quiet: don't print anything --list-tests: only list test names

tst_TestBase: add two more test cases

4d7034e

Not yet done though

tst_TestBase: test disabled tests

9c10d3a

tst_TestBase: add test for shouldTime

136e183

tests/flit_src: add tests for time_function for TestBase::run()

5b8edb4

tests: create fsutil.h

d5b3ecb

tests: Move harness tests into harness subdir

3d4f4e8

Also add empty tests for fsutils.cpp

fsutil: make functions inline

8a60b85

It worked before, but only because each test executable is made up of only one compilation unit, otherwise we may otherwise get a duplicate item error if more than one compilation unit would make up a test executable.

tests/fsutil.h: include needed header stdexcept

af572d3

For std::runtime_error to be thrown

tests/fsutil.h: include <ios> for std::ios_base::failure

1b21a22

Travis-CI: get working with GCC 4.8 despite C++11 support

80e0875

I tried to move to GCC 4.9 in Travis-CI, but with difficulty. So, I instead found workarounds for using GCC 4.8.4

fsutil: fix rec_rmdir()

7146e25

flit_src/tst_TestBase: implement run_outputFileUsingFilebase

2249ac8

tests/flit_src/tst_TestBase.cpp: finish run() tests

172f8ac

TestBase: add abs() to default compare

da41e12

tests/fsutil.h: add helper functions

d1d62f7

Added mkdir(), rmdir(), chdir(), and curdir().

tests/fsutil.h: add touch() method

2b3b5c2

mikebentley15 added the tests Involves touching tests label Jun 11, 2019

mikebentley15 added 17 commits June 10, 2019 22:16

Travis-CI: add debugging stuff

39c5058

Travis-CI: more debugging

cc27719

tests/fsutil.h: use only ios_base::failure exceptions

8ad27ab

tests/fsutil.h: add stdexcept include

96c5b48

Travis-CI: remove debugging code

b3efafe

docs: update variant and comparison() documentation

bcd0644

tst_Variant: add more challenging string tests

629ef19

Variant: change toString() output of string type

f2c52fa

test_harness.h: fix misspelling

f2fd176

Fix broken tests

67467bc

Variant: almost get vector<string> working

97d2b5b

Variant: fix many of the tests

fff2cd7

tests/tst_Variant: fix all tests and associated code

1966ea3

TestBase: use the new stringVector variant type

fc92951

docs: describe returning vector<string>

24d921d

Merge branch 'issue49-return-vectorstring' into issue49-return-vectors

395451d

tst_TestBase: add tests for vector<string>

7d35c3f

mikebentley15 commented Jun 11, 2019

View reviewed changes

IanBriggs reviewed Jun 11, 2019

View reviewed changes

tests/fsutil.h Outdated Show resolved Hide resolved

IanBriggs reviewed Jun 11, 2019

View reviewed changes

IanBriggs approved these changes Jun 11, 2019

View reviewed changes

mikebentley15 added 2 commits June 11, 2019 14:46

Fix some review findings

8493b53

fsutil: move many things out of the header into cpp

6a05a5a

mikebentley15 force-pushed the issue49-return-vectors branch from 72cb1a8 to 6a05a5a Compare June 11, 2019 22:03

fsutil.h: corrected which readfile() was inline

691cbd6

mikebentley15 merged commit c5af645 into devel Jun 11, 2019

mikebentley15 deleted the issue49-return-vectors branch June 11, 2019 22:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue49 return vectors #271

Issue49 return vectors #271

mikebentley15 commented Jun 10, 2019

mikebentley15 commented Jun 11, 2019

mikebentley15 commented Jun 11, 2019

mikebentley15 left a comment

IanBriggs left a comment

Issue49 return vectors #271

Issue49 return vectors #271

Conversation

mikebentley15 commented Jun 10, 2019

mikebentley15 commented Jun 11, 2019

mikebentley15 commented Jun 11, 2019

mikebentley15 left a comment

Choose a reason for hiding this comment

IanBriggs left a comment

Choose a reason for hiding this comment