Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue222 mpich support #264

Merged
merged 4 commits into from
May 20, 2019
Merged

Issue222 mpich support #264

merged 4 commits into from
May 20, 2019

Conversation

mikebentley15
Copy link
Collaborator

Fixes #222

Description:
Add support for MPICH within Makefile.in

Documentation:
In the installation section, I described how to optionally install MPICH as an alternative to OpenMPI. This implies that we support both OpenMPI and MPICH. Say something if you think more documentation is necessary.

Tests:
In TravisCI, I enabled running the tests with MPICH, so this will now be tested for every push.

@mikebentley15 mikebentley15 requested a review from IanBriggs May 17, 2019 22:28
@mikebentley15 mikebentley15 added bug documentation Involves touching documentation make Involves touching GNU Makefiles tests Involves touching tests labels May 17, 2019
Copy link
Collaborator

@IanBriggs IanBriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way of keeping it all in the makefile

@IanBriggs IanBriggs merged commit 3d6a83d into devel May 20, 2019
@IanBriggs IanBriggs deleted the issue222-mpich-support branch May 20, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Involves touching documentation make Involves touching GNU Makefiles tests Involves touching tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI support: does not work with MPICH
2 participants