Issue175 bisect test one arg #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more in line with delta debugging. It makes it so that we only pass in the list of objects we want to test. It is really implementation details for the problem being addressed that says we actually care about the complement. Also, the complement is easy enough to compute in the test function without adding unnecessary computational complexity
|
Ian, would you do me the pleasure of reviewing my code? You are welcome to put in comments, checkout the branch and do the fixes, or both. Something I learned doing the last code review, when you go to make your first comment in the code, click on "Start a review" rather than just "comment". It will register all of your comments as part of your code review. Then when you're done, click on "Review changes" at the top and say what the final result of your review is to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #175 so that the
is_bad()function passed tobisect_search()only takes the list of variables to test, and not the complement.I also added a unit test for bisect that actually tests to see if bisect can identify blamed files and symbols. This partially addresses #137. It is fairly comprehensive for the basic functionality of bisect. It does not address all of the features of bisect. It is also a bit too hard-coded to the current behavior and is not very generic and is able to break from small changes to bisect implementation.
Documentation: this change does not change anything that is specified in the documentation, so no changes here necessary
Testing: test is added and all tests pass