Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade artifact actions to v4 #4444

Merged
merged 18 commits into from
May 2, 2024
Merged

Conversation

max-sixty
Copy link
Member

No description provided.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, I think this is still not enough. A step is required to merge multiple artifacts.
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#merging-multiple-artifacts

I'll take a look when I have time today.

@max-sixty
Copy link
Member Author

If I understand correctly, I think this is still not enough. A step is required to merge multiple artifacts.
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#merging-multiple-artifacts

I don't think so!

From: https://github.com/actions/upload-artifact/blob/main/merge/README.md

For most cases, this may not be the most efficient solution. See the migration docs on how to download multiple artifacts to the same directory on a runner. This action should only be necessary for cases where multiple artifacts will need to be downloaded outside the runner environment, like downloads via the UI or REST API.

@eitsupi
Copy link
Member

eitsupi commented May 2, 2024

I suppose python release will fail.

@max-sixty
Copy link
Member Author

I think everything is fixed now! If you spot anything let me know and I'll come back to it...

@max-sixty max-sixty enabled auto-merge (squash) May 2, 2024 02:36
@max-sixty max-sixty merged commit d29f102 into PRQL:main May 2, 2024
83 checks passed
@max-sixty max-sixty deleted the artifact-4 branch May 2, 2024 02:48
@eitsupi eitsupi mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants