docs: Create ace-demo.html #3512
Conversation
for more information, see https://pre-commit.ci
|
OK cool. Would be nice to have some sort of test / check that it's still working correctly, but I guess that's difficult with HTML. Shall we link to this from the grammars readme? Otherwise it's totally orphaned. Separately, we could add the link from #3493 (comment) too. |
|
If you want to spend more time with grammars, adding tests for our existing grammars would be really helpful. And one huge win would be allowing the PRQL lezer grammar to work in Jupyter notebooks. The grammar is our best grammar, and is the format (CodeMirror) required for Jupyter notebooks, but the integration hasn't been writen. That would be a difficult project but would immensely valuable. |
for more information, see https://pre-commit.ci
grammars/README.md
Outdated
| @@ -9,6 +9,8 @@ an index. | |||
|
|
|||
| - [Ace](https://ace.c9.io/) — supported. The grammar is upstream | |||
| ([prql_highlight_rules.js](https://github.com/ajaxorg/ace/blob/master/src/mode/prql_highlight_rules.js)). | |||
| See the | |||
| [demo](https://htmlpreview.github.io/?https://github.com/PRQL/prql/blob/main/grammars/ace-demo.html). | |||
There was a problem hiding this comment.
Does this work? I'm not sure I'm doing it right but if I try https://htmlpreview.github.io/?https://github.com/PRQL/prql/blob/0bcb3d530aa9eb411a9c09380738732f5be1407f//grammars/ace-demo.html, I just get some text.
There was a problem hiding this comment.
Ugh, I had hoped so, but I guess not. I can move to /web/website/content/ though.
There was a problem hiding this comment.
(need to update link too :) )
There was a problem hiding this comment.
I hope this works!
grammars/README.md
Outdated
| @@ -9,6 +9,7 @@ an index. | |||
|
|
|||
| - [Ace](https://ace.c9.io/) — supported. The grammar is upstream | |||
| ([prql_highlight_rules.js](https://github.com/ajaxorg/ace/blob/master/src/mode/prql_highlight_rules.js)). | |||
| See the [demo](https://prql-lang.org/ace-demo). | |||
There was a problem hiding this comment.
I didn't realize this was a top-level page. Could we put it down a level to indicate that it's not a sibling of the key pages? Maybe a content/demos/ace-demo.html page?
There was a problem hiding this comment.
Sounds good.
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-web web
# Navigate to the new working tree
cd .worktrees/backport-web
# Create a new branch
git switch --create backport-3512-to-web
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8feaca87c566e1f951f4212e1e6669e702bbfbc1
# Push it to GitHub
git push --set-upstream origin backport-3512-to-web
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-webThen, create a pull request where the |
|
We're doing a release v soon anyway, so it'll publish then |
This is a demo of using Ace with the PRQL syntax highlighting mode.