Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: report the fraction of unassigned reads #21

Closed
jnalanko opened this issue Apr 6, 2023 · 1 comment · Fixed by #23
Closed

Feature request: report the fraction of unassigned reads #21

jnalanko opened this issue Apr 6, 2023 · 1 comment · Fixed by #23
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@jnalanko
Copy link
Contributor

jnalanko commented Apr 6, 2023

Hi, thanks for making this great tool!

It would be nice to know the fraction of the sample that could not be assigned to any target sequence. This would give an idea for how much of the sample is noise or outside of the pseudoalignment reference database. I know I can already get an idea of this number by parsing the pseudoalignment file myself, but it would be convenient if mSWEEP reported this in the comment section of the output file.
@tmaklin tmaklin added this to the v2.0.0 milestone Apr 12, 2023
@tmaklin tmaklin added the enhancement New feature or request label Apr 12, 2023
tmaklin added a commit that referenced this issue Apr 24, 2023
@tmaklin
Write the total number of reads in the output file (see #21).
a7bf816
@tmaklin
Copy link
Collaborator

tmaklin commented Apr 24, 2023

Added in a7bf816. Note: this is a breaking change to the output format and will incorporated in v2.0.0 release currently in development.

@tmaklin tmaklin mentioned this issue Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

mSWEEP v2.0.0 PROBIC/mSWEEP
2 participants
@jnalanko @tmaklin