Skip to content

Commit

Permalink
[FIX] Update rate limiter acquire method and fix circular imports
Browse files Browse the repository at this point in the history
Improves rate limiter behavior and resolves test failures by properly
implementing burst limit checks in acquire(). Fixes circular dependency
by moving BCRAApiError to a dedicated exceptions module.

 - Updates acquire() to correctly handle burst limits and delays
 - Creates exceptions.py module to resolve circular imports
 - Ensures consistent rate limiting behavior in tests
  • Loading branch information
PPeitsch committed Dec 28, 2024
1 parent c176fb5 commit 26147bd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/bcra_connector/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .__about__ import __version__
from .exceptions import BCRAApiError
from .bcra_connector import BCRAConnector
from .cheques import Cheque, ChequeDetalle, ChequeResponse, Entidad, EntidadResponse
from .cheques import ErrorResponse as ChequesErrorResponse
Expand All @@ -13,6 +12,7 @@
)
from .estadisticas_cambiarias import ErrorResponse as CambiariasErrorResponse
from .estadisticas_cambiarias import Metadata, Resultset
from .exceptions import BCRAApiError
from .principales_variables import DatosVariable, PrincipalesVariables
from .rate_limiter import RateLimitConfig
from .timeout_config import TimeoutConfig
Expand Down
2 changes: 1 addition & 1 deletion src/bcra_connector/bcra_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@

from .cheques import Cheque, Entidad
from .estadisticas_cambiarias import CotizacionDetalle, CotizacionFecha, Divisa
from .exceptions import BCRAApiError
from .principales_variables import DatosVariable, PrincipalesVariables
from .rate_limiter import RateLimitConfig, RateLimiter
from .timeout_config import TimeoutConfig
from .exceptions import BCRAApiError


class BCRAConnector:
Expand Down
1 change: 1 addition & 0 deletions src/bcra_connector/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@

class BCRAApiError(Exception):
"""Custom exception for BCRA API errors."""

pass

0 comments on commit 26147bd

Please sign in to comment.