Mutiple img tag Regex fix. #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow multiple img tags to be replaced with [image] tags.
Multiple img Regex fix
|
@danieljfrench thanks for the PR... can you add unit tests, please? |
…l_nonsequential_images Parse sequential / nonsequential images tests.
|
@jeffputz - no problem, added now. Two new unit tests added to src/PopForums.Test/Services/TextParsingServiceClientHtmlToForumCodeTests.cs |
|
@jeffputz - thanks Jeff. Any chance of the v17.x nuget feed being updated? |
|
@danieljfrench yeah, I'll have to push a new release. Give me a little time on that today... |
|
@danieljfrench v17.0.1 for the core library is up on Nuget. Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I had a requirement to be able to put multiple img elements sequentially in a post. When submitted and run through the textparsingservice, the regex logic was only finding the last img tag, and replacing with the forum [image] code. The Regex was being too greedy.
Fix
The "greediness" of the Regex has been changed to allow it to match multiple img tags (.? rather than .). This SO post helped with determining what was happening: https://stackoverflow.com/questions/2301285/what-do-lazy-and-greedy-mean-in-the-context-of-regular-expressions.
Testing
Have tested locally with sequential and non-sequantial images and the issue seems resolved.