-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update domain from twitter.com to x.com #532
Conversation
Approved! |
I won't trigger a new version for now, as it's not really necessary, but thank you |
@PLhery I'm using this lib for my app and would love if it could generate the Auth URL as x.com though so users won't need to redirect when authorizing my application. |
It makes sense, I will create a new version tonight! |
released in 1.17.0! |
looks like oauth 1 with x.com stopped working. "login" button on the https://api.x.com/oauth redirects to api.twitter.com, where I get the following error: |
Thank you, I'm reverting the commit |
Reverted in 1.17.1 |
I upgraded to 1.17.0, and the oauth2 flow worked great on x.com :) |
Any second person could confirm this? Then I'd re-revert |
Can confirm x.com works great for OAuth 2. Using twitter.com forces the user to login again. |
twitter.com -> x.com published again in 1.18.0 |
This PR is based on Elon's tweet: https://x.com/elonmusk/status/1791351500217754008
Please help review @PLhery