Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update domain from twitter.com to x.com #532

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

melvinmcrn
Copy link
Contributor

@melvinmcrn melvinmcrn commented May 20, 2024

This PR is based on Elon's tweet: https://x.com/elonmusk/status/1791351500217754008

Please help review @PLhery

@PLhery
Copy link
Owner

PLhery commented May 20, 2024

Approved!

@PLhery PLhery merged commit 8dc65e6 into PLhery:master May 20, 2024
@PLhery
Copy link
Owner

PLhery commented May 20, 2024

I won't trigger a new version for now, as it's not really necessary, but thank you

@melvinmcrn
Copy link
Contributor Author

@PLhery I'm using this lib for my app and would love if it could generate the Auth URL as x.com though so users won't need to redirect when authorizing my application.

@PLhery
Copy link
Owner

PLhery commented May 21, 2024

It makes sense, I will create a new version tonight!

@PLhery
Copy link
Owner

PLhery commented May 23, 2024

released in 1.17.0!

@Dubzer
Copy link

Dubzer commented Jun 2, 2024

looks like oauth 1 with x.com stopped working. "login" button on the https://api.x.com/oauth redirects to api.twitter.com, where I get the following error:

image

@PLhery
Copy link
Owner

PLhery commented Jun 2, 2024

Thank you, I'm reverting the commit

PLhery added a commit that referenced this pull request Jun 3, 2024
@PLhery
Copy link
Owner

PLhery commented Jun 3, 2024

Reverted in 1.17.1

@avoc-ado
Copy link

avoc-ado commented Jul 13, 2024

I upgraded to 1.17.0, and the oauth2 flow worked great on x.com :)

@PLhery
Copy link
Owner

PLhery commented Jul 13, 2024

Any second person could confirm this? Then I'd re-revert

@dylan1951
Copy link

Can confirm x.com works great for OAuth 2. Using twitter.com forces the user to login again.

PLhery pushed a commit that referenced this pull request Oct 6, 2024
PLhery pushed a commit that referenced this pull request Oct 6, 2024
@PLhery
Copy link
Owner

PLhery commented Oct 6, 2024

twitter.com -> x.com published again in 1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants