Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sort_order to v2 search params #246

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

nolbuzanis
Copy link
Contributor

Fixes #236

@PLhery
Copy link
Owner

PLhery commented Mar 29, 2022

Related: #237

Co-authored-by: Paul-Louis HERY <paullouis.hery@gmail.com>
@nolbuzanis
Copy link
Contributor Author

Hoping to get more involved with this project if you need more help!

@alkihis
Copy link
Collaborator

alkihis commented Mar 30, 2022

Many thanks for your PR! I will take a look in the next few days when I have time for this 😄

@PLhery
Copy link
Owner

PLhery commented Mar 30, 2022

LGTM, merging :) thank you

@PLhery
Copy link
Owner

PLhery commented Mar 30, 2022

And thanks a million, any future contribution would be really appreciated, ex on the #237 ☺️

@PLhery PLhery merged commit f95eed1 into PLhery:master Mar 30, 2022
@nolbuzanis
Copy link
Contributor Author

Sounds good!

@nolbuzanis nolbuzanis deleted the fix/v2-search-params branch March 30, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] support sort_order search parameter
3 participants