really weird issue - adding asterisk * to a tweet text breaks the api

[faisalsayed10]

okay so i found this weird issue while working with this api that whenever I add * to my tweet message, it literally breaks the api. Here's what's happening with me:

tweet = await twitterApi.v1.tweet("this is a *tweet*", { tweet_mode: "extended" });

^ this won't work, while if i tweet literally anything else which doesn't include asterisk, it will succeed. I have no idea how this happens, even tried using direct post methods, still breaks.

After this, I tested twitter-api-client and that doesn't break at all.

[alkihis]

Hi, thanks for your submission.
It seems to break OAuth signature and -consequently- breaks the subsequent request.
I'll check for a possible fix asap :)

[alkihis]

Ok, for some reason, URLSearchParams object doesn't encode * when you transform it to a query string.
When Twitter expects a query string (GET/DELETE) or a url encoded body (every POST endpoint of v1.1), with a * into values, error was thrown. :)

return new URLSearchParams(body)
  .toString()
  .replace(/\*/g, '%2A'); // URLSearchParams doesnt encode '*', but Twitter wants it encoded.

Will be merged soon with other fixes and improvements.

[faisalsayed10]

wow thanks for the quick response and also fixing it really quick!