Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usertimeline v1 endpoint .done property value is false even after it has fetched all tweets #238

Closed
rishabhgarg7 opened this issue Mar 26, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rishabhgarg7
Copy link

Bug:

v1.userTimeline method's result done property has value equal to false even when it has fetched all tweets. I think it's only happening when there is only one page(haven't tested for multiple pages example yet)

To Reproduce:

  1. Using read access client.
  2. Code:
const userTimeline = await client.v1.userTimeline(userID, {
    tweet_mode: "compat",
    count: 200,
    include_entities: false,
    exclude_replies: true,
    trim_user: true,
  });
userTimeline.done -> is giving false value
  1. Tested for this account: https://twitter.com/Rishabh12646510 (only have two tweets)

Expected behavior:
userTimeline.done -> should give true value

Version

  • Node.js version: 14.17.1
  • Lib version: 1.11.2
  • OS: MacOS
@alkihis
Copy link
Collaborator

alkihis commented Mar 30, 2022

Seems like a bug, but in v1 it could be quite hard to store the information that fetch is complete, without needing an dedicated boolean. I will take a look of how it could avoid it to happen.

@alkihis
Copy link
Collaborator

alkihis commented Apr 7, 2022

Should be fixed in 1.11.3.

@alkihis alkihis closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants