Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

659 array of struct no type hint available for assignment #684

Merged

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Dec 6, 2022

No description provided.

@99NIMI 99NIMI linked an issue Dec 6, 2022 that may be closed by this pull request
@99NIMI 99NIMI requested review from riederm and ghaith December 6, 2022 12:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 94.11% // Head: 94.12% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8de06c6) compared to base (1f0b143).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   94.11%   94.12%   +0.01%     
==========================================
  Files          46       46              
  Lines       18783    18787       +4     
==========================================
+ Hits        17678    17684       +6     
+ Misses       1105     1103       -2     
Impacted Files Coverage Δ
src/resolver.rs 97.67% <100.00%> (+<0.01%) ⬆️
src/parser/expressions_parser.rs 93.84% <0.00%> (-0.13%) ⬇️
src/validation.rs 98.32% <0.00%> (+0.27%) ⬆️
src/validation/variable_validator.rs 88.00% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ghaith
ghaith previously requested changes Dec 6, 2022
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The places where initial values of an internal struct were not added are missing on purpose, that is to say some of them at least were.
We should be able to initialize a struct given only part of its initialization value.
Nevermind, I misread the tests

@ghaith ghaith dismissed their stale review December 6, 2022 13:49

Wrong comment

@99NIMI 99NIMI merged commit 7d27e00 into master Dec 12, 2022
@99NIMI 99NIMI deleted the 659-array-of-struct-no-type-hint-available-for-assignment branch December 12, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array of struct - no type hint available for Assignment
3 participants