Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#604 recursive function calls #606

Merged

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Oct 18, 2022

No description provided.

@99NIMI 99NIMI requested review from ghaith, riederm and mhasel October 18, 2022 13:06
@99NIMI 99NIMI linked an issue Oct 18, 2022 that may be closed by this pull request
@99NIMI 99NIMI requested a review from ghaith October 19, 2022 09:41
ghaith
ghaith previously approved these changes Oct 19, 2022
@99NIMI 99NIMI requested a review from ghaith October 19, 2022 11:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 93.66% // Head: 93.60% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e520524) compared to base (0793e62).
Patch coverage: 99.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   93.66%   93.60%   -0.07%     
==========================================
  Files          44       44              
  Lines       16586    16626      +40     
==========================================
+ Hits        15535    15562      +27     
- Misses       1051     1064      +13     
Impacted Files Coverage Δ
src/resolver/const_evaluator.rs 90.09% <88.88%> (-0.03%) ⬇️
src/codegen/generators/variable_generator.rs 93.75% <100.00%> (+0.27%) ⬆️
src/index/visitor.rs 96.47% <100.00%> (-0.02%) ⬇️
src/resolver.rs 97.25% <100.00%> (+0.07%) ⬆️
src/tests/adr/enum_adr.rs 100.00% <100.00%> (ø)
src/tests/adr/pou_adr.rs 100.00% <100.00%> (ø)
src/validation/variable_validator.rs 84.00% <0.00%> (-4.67%) ⬇️
src/index/const_expressions.rs 87.50% <0.00%> (-0.74%) ⬇️
src/index.rs 97.12% <0.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@99NIMI 99NIMI merged commit 01be035 into PLC-lang:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAR_INPUT and VAR_IN_OUT assignment error
3 participants