Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate Pointer - Numerics assignments if it is no perfect match #516

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

flavioBachmann
Copy link
Contributor

@flavioBachmann flavioBachmann commented Jul 14, 2022

Resolved Issue #395 by validating Pointers tests added

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #516 (e9f6a16) into master (ece0315) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   93.00%   93.04%   +0.03%     
==========================================
  Files          40       40              
  Lines       14548    14584      +36     
==========================================
+ Hits        13531    13569      +38     
+ Misses       1017     1015       -2     
Impacted Files Coverage Δ
src/typesystem.rs 96.25% <ø> (+0.34%) ⬆️
src/diagnostics.rs 83.88% <100.00%> (+0.34%) ⬆️
src/validation/stmt_validator.rs 98.20% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece0315...e9f6a16. Read the comment docs.

@flavioBachmann flavioBachmann changed the title validate Pointer - Numerics assignments if it is no perfect match #395 validate Pointer - Numerics assignments if it is no perfect match Jul 14, 2022
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you

@ghaith ghaith merged commit 151bbc7 into PLC-lang:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants