Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation-only flag (--check) #510

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

ulmer-a
Copy link
Collaborator

@ulmer-a ulmer-a commented Jun 22, 2022

Hi guys, hope you're doing well! I had some spare time, so I thought I'd catch up with the project and drop you a PR. Things are moving quickly...!

This should fix #482.

I split up compile_module() into index_module() and compile_module() so that the two can be called independently (the check option then only calls index_module and doesn't generate code).

Hope it helps!

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #510 (6882a7b) into master (d667f20) will decrease coverage by 0.00%.
The diff coverage is 86.02%.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   93.00%   92.99%   -0.01%     
==========================================
  Files          40       40              
  Lines       14468    14523      +55     
==========================================
+ Hits        13456    13506      +50     
- Misses       1012     1017       +5     
Impacted Files Coverage Δ
src/lib.rs 75.72% <77.08%> (+0.36%) ⬆️
src/cli.rs 97.94% <95.55%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d667f20...6882a7b. Read the comment docs.

@riederm
Copy link
Collaborator

riederm commented Jun 23, 2022

Hi Alex,

so nice hearing from you! thx for the PR - i'll check it these days.

Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Alex! Nice to hear from you again :)

Thank you for your contribution, this looks good!

@ghaith ghaith merged commit ea85484 into PLC-lang:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a validation-only run
4 participants