Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation for array access added, tests added #451

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Feb 2, 2022

No description provided.

@99NIMI 99NIMI linked an issue Feb 2, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #451 (5bcdc77) into master (425cf93) will increase coverage by 0.00%.
The diff coverage is 97.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   93.41%   93.42%           
=======================================
  Files          32       32           
  Lines       12287    12375   +88     
=======================================
+ Hits        11478    11561   +83     
- Misses        809      814    +5     
Impacted Files Coverage Δ
src/validation/stmt_validator.rs 98.06% <95.74%> (-0.27%) ⬇️
src/diagnostics.rs 84.41% <100.00%> (+1.19%) ⬆️
src/typesystem.rs 95.53% <100.00%> (+0.04%) ⬆️
src/index.rs 97.49% <0.00%> (-0.72%) ⬇️
src/validation.rs 93.10% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425cf93...5bcdc77. Read the comment docs.

@99NIMI 99NIMI requested review from ghaith and riederm February 2, 2022 10:19
@ghaith ghaith merged commit 40977ab into master Feb 4, 2022
@ghaith ghaith deleted the issue-80-Array_Validation branch February 4, 2022 08:25
riederm pushed a commit that referenced this pull request Feb 6, 2022
* validation for array access added, tests added

* added tests, check for int instead of nummeric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating Array Access (operator type, array-access)
3 participants