Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow optional output assignments, empty assignments will be ignored … #437

Merged
merged 4 commits into from
Jan 19, 2022

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Jan 19, 2022

…in codegen

@99NIMI 99NIMI requested review from riederm and ghaith January 19, 2022 14:35
@99NIMI 99NIMI linked an issue Jan 19, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #437 (6b663cf) into master (0d5289f) will increase coverage by 0.00%.
The diff coverage is 82.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   93.32%   93.33%           
=======================================
  Files          32       32           
  Lines       12001    12003    +2     
=======================================
+ Hits        11200    11203    +3     
+ Misses        801      800    -1     
Impacted Files Coverage Δ
src/codegen/generators/expression_generator.rs 88.51% <82.35%> (+0.01%) ⬆️
src/index.rs 97.31% <0.00%> (-0.72%) ⬇️
src/validation.rs 93.10% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5289f...6b663cf. Read the comment docs.

@riederm
Copy link
Collaborator

riederm commented Jan 19, 2022

cool

@ghaith ghaith merged commit 03a87c9 into master Jan 19, 2022
@ghaith ghaith deleted the issue-412-output_parameter_should_be_optional branch January 19, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output parameter should be optional
4 participants