Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess arrays and pointers #300

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Preprocess arrays and pointers #300

merged 2 commits into from
Sep 24, 2021

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Sep 24, 2021

Fixes #280

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #300 (0982c31) into master (ab1d310) will decrease coverage by 0.41%.
The diff coverage is 90.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   95.27%   94.85%   -0.42%     
==========================================
  Files          44       45       +1     
  Lines       12051    12819     +768     
==========================================
+ Hits        11481    12159     +678     
- Misses        570      660      +90     
Impacted Files Coverage Δ
src/codegen/generators/struct_generator.rs 88.42% <67.50%> (-10.49%) ⬇️
src/resolver.rs 96.15% <73.68%> (-0.43%) ⬇️
src/compile_error.rs 51.85% <75.00%> (+13.75%) ⬆️
src/index.rs 92.36% <77.14%> (-4.17%) ⬇️
src/codegen/generators/expression_generator.rs 88.36% <86.66%> (-0.06%) ⬇️
src/resolver/const_evaluator.rs 89.34% <89.34%> (ø)
src/codegen/generators/variable_generator.rs 98.36% <92.30%> (-1.64%) ⬇️
src/index/const_expressions.rs 93.93% <94.38%> (+0.60%) ⬆️
src/ast/pre_processor.rs 100.00% <100.00%> (ø)
src/codegen.rs 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3e63c...0982c31. Read the comment docs.

@ghaith ghaith requested a review from riederm September 24, 2021 07:41
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghaith ghaith merged commit 17653f6 into master Sep 24, 2021
@ghaith ghaith deleted the issue280 branch September 24, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derived types are not preprocessed
2 participants