Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exponents on the lexer side, treat them as integer #263

Merged
merged 6 commits into from
Aug 31, 2021

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Aug 27, 2021

Treat the exponents as part of the integer.
Add tests using E1.. as an identifier
Add support for exponents without the 0

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #263 (0cd772f) into master (3d61764) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   94.90%   94.89%   -0.02%     
==========================================
  Files          42       42              
  Lines       11169    11184      +15     
==========================================
+ Hits        10600    10613      +13     
- Misses        569      571       +2     
Impacted Files Coverage Δ
src/parser/expressions_parser.rs 96.18% <80.00%> (-0.76%) ⬇️
src/ast.rs 90.08% <0.00%> (+0.16%) ⬆️
src/typesystem.rs 96.97% <0.00%> (+0.25%) ⬆️
src/validation.rs 80.97% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d61764...0cd772f. Read the comment docs.

@ghaith ghaith linked an issue Aug 27, 2021 that may be closed by this pull request
@ghaith ghaith requested a review from riederm August 30, 2021 06:01
@ghaith ghaith merged commit 45b4df6 into master Aug 31, 2021
@ghaith ghaith deleted the ghaith/issue249 branch August 31, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat keywords as identifiers if they are in the Identifier's place
2 participants