Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid filenames not printing an error #235

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

ulmer-a
Copy link
Collaborator

@ulmer-a ulmer-a commented Aug 12, 2021

This will resolve #232

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #235 (0bac55e) into master (7e18300) will increase coverage by 0.06%.
The diff coverage is 98.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   93.52%   93.58%   +0.06%     
==========================================
  Files          34       34              
  Lines        9054     9173     +119     
==========================================
+ Hits         8468     8585     +117     
- Misses        586      588       +2     
Impacted Files Coverage Δ
src/index.rs 94.40% <ø> (ø)
src/index/visitor.rs 96.18% <0.00%> (-0.37%) ⬇️
src/lexer.rs 95.32% <ø> (ø)
src/parser.rs 97.86% <99.42%> (+0.27%) ⬆️
src/ast.rs 87.83% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c7ea6...0bac55e. Read the comment docs.

@ulmer-a ulmer-a merged commit 04bcbda into PLC-lang:master Aug 12, 2021
@ulmer-a ulmer-a deleted the fix_filepath_bug branch August 12, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rusty succeeding when invoked with invalid filename
2 participants