Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing datatypes #342

Closed
rarris opened this issue Oct 27, 2021 · 4 comments
Closed

add missing datatypes #342

rarris opened this issue Oct 27, 2021 · 4 comments
Assignees
@99NIMI
Labels
bug Something isn't working good first issue Good for newcomers language feature (norm) a missing language feature according to iec61131-3

Comments

@rarris
Copy link
Contributor

rarris commented Oct 27, 2021

these datatypes are missing and need to be implemented

LTIME
LDATE
LDT
LTOD
@rarris rarris added the bug Something isn't working label Oct 27, 2021
@ghaith
Copy link
Collaborator

ghaith commented Oct 27, 2021

We could probably implement these types as aliases since our TIME/DATE/DT/TOD types are already 64 bit

@riederm
Copy link
Collaborator

riederm commented Oct 27, 2021

We could probably implement these types as aliases since our TIME/DATE/DT/TOD types are already 64 bit

agreed

@riederm
Copy link
Collaborator

riederm commented Oct 27, 2021

I reconsidered this and it looks like we have LiteralDate / LiteralDateAndTime / etc. tokens. This means that DATE, DATE_AND_TIME, etc. are hardcoded in the lexer 🤔

@riederm riederm added language feature (norm) a missing language feature according to iec61131-3 bug Something isn't working and removed bug Something isn't working labels Oct 29, 2021
@riederm riederm added the good first issue Good for newcomers label Nov 25, 2021
@99NIMI 99NIMI self-assigned this May 24, 2022
@create-issue-branch
Copy link

Branch issue-342-add_missing_datatypes created!

99NIMI added a commit to 99NIMI/rusty that referenced this issue May 24, 2022
@99NIMI
PLC-lang#342 added long date types
d82fa3d
ghaith pushed a commit that referenced this issue May 25, 2022
@99NIMI
#342 added long date types (#490)
21a1df8
@ghaith ghaith closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@99NIMI 99NIMI

Labels
bug Something isn't working good first issue Good for newcomers language feature (norm) a missing language feature according to iec61131-3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ghaith @riederm @rarris @99NIMI