-
Notifications
You must be signed in to change notification settings - Fork 4
♻️ Modernize the Hugging Face bridge #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: datasets_roadmap
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TODO: implement typing and docstring for all added code, and transform the two files added in tests/bridges into a jupytext example (to compile with the doc) - and ruff formatting |
def get_mem(): | ||
"""Get the current memory usage of the process in MB.""" | ||
process = psutil.Process(os.getpid()) | ||
return process.memory_info().rss / (1024**2) # in MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it should be in plaid, as it is only used in examples, maybe in examples/utils.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Checklist
PR Summary
This PR modernizes the Hugging Face bridge by:
DatasetDict
: leverage the native split mechanism for efficient partial dataset access.problem_definition
andinfos
in the dataset description; provide clear functions to load/save them via JSON and YAML.HF PLAID datasets conversion
Current PLAID datasets can be downloaded, converted and uploaded with:
Results here
Then:
gives:
Splits
These modification drop the support for "subsplits": we only rely on "main split", the one defined natively through the DatasetDict. Hence,
splits
in problem_definition are ignored by the Hugging Face bridge.🔗 Related issues
Addresses tasks from
#160
#241
#219