Skip to content

Commit

Permalink
Include our Azure client ID in AzureConnection
Browse files Browse the repository at this point in the history
Some folks over in MSAL land told us that client IDs don't need to be kept secret.

This reduces the delta between "public" terminal and "release build" terminal by one more file, leaving only the telemetry header left (which won't be going public for obvious reasons).

This will also make it easier for contributors to test out Azure Cloud Shell changes... and testing out VT without ConPTY interfeing[^1]

[^1]: When Dev branding is selected, Azure Cloud Shell has the added perk of being wired directly to TerminalCore rather than going through ConPTY.
  • Loading branch information
DHowett committed Aug 22, 2023
1 parent 333fcd8 commit c8e857f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cascadia/TerminalConnection/AzureClientID.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

#pragma once

inline constexpr std::wstring_view AzureClientID = L"0";
inline constexpr std::wstring_view AzureClientID{ L"245e1dee-74ef-4257-a8c8-8208296e1dfd" };

0 comments on commit c8e857f

Please sign in to comment.