Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder C{,Mutable}Transaction for better packing #2460

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Reorder C{,Mutable}Transaction for better packing #2460

merged 1 commit into from
Jul 19, 2021

Conversation

random-zebra
Copy link

Adapts bitcoin#8330.

sizeof(CTransaction) and sizeof(CMutableTransaction) show a reduction of 8 bytes.

@random-zebra random-zebra self-assigned this Jun 28, 2021
@random-zebra random-zebra added this to the 6.0.0 milestone Jun 28, 2021
furszy
furszy approved these changes Jul 5, 2021
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting PR, tested ACK c602135.
256 bytes without it, 248 with it.

@furszy furszy merged commit a306efd into PIVX-Project:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

Assignees

@random-zebra random-zebra

Labels
Refactoring Upstream
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@random-zebra @furszy