Move zerocoin validation to its own legacy file. #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Jul 11, 2020
random-zebra
added
the
Needs Backport
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 22, 2020
… own legacy file method. Github-Pull: PIVX-Project#1733 Rebased-From: 81d2654
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 22, 2020
Github-Pull: PIVX-Project#1733 Rebased-From: 5e81e5d
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 22, 2020
Github-Pull: PIVX-Project#1733 Rebased-From: 01aca7c
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 22, 2020
Github-Pull: PIVX-Project#1733 Rebased-From: bd4c1b1
furszy
added a commit
that referenced
this pull request
Jul 24, 2020
dd22385 [GUI] Update translations from transifex (Fuzzbawls) 919e060 Solving old, not loaded at startup, transactions notification issue. (furszy) 943d84b NU name words separated by underscore instead of white space. (furszy) fc042f1 Fixing UpgradeIndex position issue. (furszy) 531673c Customize network upgrades activation height for regtest at the startup. (furszy) 1337685 Sapling activation height for regtest (furszy) 15b1052 Miner: Unused reserveKey cleanup (furszy) 566b6fc [GUI] Load persisted transaction filter/sort during start (V3) (Mrs-X) 5d22583 [GUI] Recognize key event for clearing console (Fuzzbawls) 77880e0 GUI: Settings console message moved to read only. (furszy) 6b63591 options model unused signals cleanup (furszy) b9e3859 GUI: Fixing settings display lang initialization (furszy) b434cbf Transaction primitive unused methods cleanup. (furszy) 7f9037f missing validation_zerocoin_legacy added to CMakeLists.txt (furszy) 22bfc12 Move-only: ATMP zerocoin check moved to its own legacy file. (furszy) 24d9ac4 Move-only: DataBaseAccChecksum to zerocoin validation legacy. (furszy) fb2993d Move-only: Move Zerocoin tx disconnection from DisconnectBlock to its own legacy file method. (furszy) eaacd29 Wallet::AddToWallet if walletdb is null, create one and write the tx. (furszy) 609407d Split CWallet::AddToWallet into AddToWallet and LoadToWallet. (furszy) 9aacb38 Prevent multiple calls to CWallet::AvailableCoins (furszy) c0e9b13 Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDisk (furszy) Pull request description: backports the following PRs that have been merged since the `4.2` branch-off: #1717 #1733 #1736 #1742 #1741 #1744 #1287 #1751 #1747 #1749 #1763 ACKs for top commit: furszy: utACK dd22385 , ready for 4.2 :) . Tree-SHA512: 38dd47320b8a7de77879240c36dec7588671fc09bc7d4f0be573fb6a33d6d243d4adbf4451bd4b4da9c046fab058c1cb0eb2ec2d97052b4d1171ac959ae5a71f
furszy
added a commit
that referenced
this pull request
Jul 26, 2020
d4cf6c8 Move disconnectBlocks logging to use __func__ instead of hardcoded method name. (furszy) 17e9b8e Simplify DisconnectBlock arguments/return value (furszy) 6d2ea62 Split logic to undo txin's off DisconnectBlock (furszy) a3a4ab5 Cleaner disconnectBlock flow for coinbase and zerocoin txs. (furszy) Pull request description: Built on top of #1733. Straightforward PR, no functional changes. Purely code cleanup and refactoring around the `DisconnectBlock` function. ACKs for top commit: random-zebra: re utACK d4cf6c8 Fuzzbawls: utACK d4cf6c8 Tree-SHA512: b97dcc61e5510713b36dec0abdf3c036e4be5c7d228cb317f398a19a922e556e07348a1e166ff0cbd49f6f204362b9994ab7749697dac2685dab87e1c7dca62b
Fuzzbawls
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a move-only PR, no functionality or code was changed.
The main idea behind this decoupling is continue cleaning main.cpp. Making new functionalities and back ports easier to implement.
Have been thinking whether this should be a new file or
zerocoin_verify.hand ended with a new file because this flows are one step above the verify methods and are not isolated from the process that calls them. Example:AcceptToMemoryPoolZerocoinworks only for theAcceptToMemoryPoolmethod.