-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the beginning of the cut trace is at or after the cut time #551
Conversation
…ove that sample, which may result in the data beginning slightly after the start of the cut time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case and lets merge this.
…in the middle of a sample
@timronan do you think testing against the following experiments is sufficient? I think the behavior is consistent enough that this does not need to be tested against as many experiments as I did for ph5availability PRs but I can test against more in case of surprises. 16-013, Texan, 10 stations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experiments that previously had data starting before 00:00:00 now start after 00:00:00. Ex. 20-003, 16-015, 19-001. Affected dataloggers: Fairfield, RT130.
Unaffected experiments have substantially the same mseed returned on this PR as on the current master branch. Ex. 16-013 (Texan), 22-005, 22-024. Extremely short segments from 22-005 and 22-024 (SmartSolo) are slightly modified, Ex. from 22-024:
Master:
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,23:59:59.995999||250|21600000|||||||2025,038
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,00:00:00.188000||250|48|||||||2025,038
This PR:
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,23:59:59.995999||250|21600000|||||||2025,038
2N|101||DPZ|2022,078,00:00:00.003999|2022,078,00:00:00.187999||250|47|||||||2025,038
However, this is not a substantive change to the 00:00:00 to 23:59:59 data requested and the returned data still meet the criteria of starting at or after the request start time of 00:00:00.
What does this PR do?
When the cut time starts in the middle of a sample the result will start slightly before the cut time.
This fix will make sure the beginning of the cut trace is at or after the cut time.
Relevant Issues?
closes #550
Checklist
CHANGELOG.txt
.CONTRIBUTORS.txt
.