Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the beginning of the cut trace is at or after the cut time #551

Merged
merged 8 commits into from
Feb 18, 2025

Conversation

damhuonglan
Copy link
Contributor

@damhuonglan damhuonglan commented Jan 29, 2025

What does this PR do?

When the cut time starts in the middle of a sample the result will start slightly before the cut time.
This fix will make sure the beginning of the cut trace is at or after the cut time.

Relevant Issues?

closes #550

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

…ove that sample, which may result in the data beginning slightly after the start of the cut time.
Copy link
Collaborator

@timronan timronan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case and lets merge this.

This reverts commit 820ad42.
…will remove that sample, which may result in the data beginning slightly after the start of the cut time."

This reverts commit 9f5b878.
@damhuonglan damhuonglan changed the title remove the redundant sample in the result if there is any Make sure the beginning of the cut trace is at or after the cut time Feb 5, 2025
@hrotman-pic
Copy link
Collaborator

@timronan do you think testing against the following experiments is sufficient? I think the behavior is consistent enough that this does not need to be tested against as many experiments as I did for ph5availability PRs but I can test against more in case of surprises.

16-013, Texan, 10 stations
16-015, Fairfield, 1 component of 1 station
19-001, RT130, all components of 1 station on 2 different days
20-003, Fairfield, 1 component of all stations
22-005, SmartSolo, 1 component of all stations
22-024, SmartSolo, 1 component of 9 stations

@hrotman-pic hrotman-pic self-requested a review February 13, 2025 15:14
Copy link
Collaborator

@hrotman-pic hrotman-pic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experiments that previously had data starting before 00:00:00 now start after 00:00:00. Ex. 20-003, 16-015, 19-001. Affected dataloggers: Fairfield, RT130.

Unaffected experiments have substantially the same mseed returned on this PR as on the current master branch. Ex. 16-013 (Texan), 22-005, 22-024. Extremely short segments from 22-005 and 22-024 (SmartSolo) are slightly modified, Ex. from 22-024:
Master:
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,23:59:59.995999||250|21600000|||||||2025,038
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,00:00:00.188000||250|48|||||||2025,038

This PR:
2N|101||DPZ|2022,078,00:00:00.000000|2022,078,23:59:59.995999||250|21600000|||||||2025,038
2N|101||DPZ|2022,078,00:00:00.003999|2022,078,00:00:00.187999||250|47|||||||2025,038
However, this is not a substantive change to the 00:00:00 to 23:59:59 data requested and the returned data still meet the criteria of starting at or after the request start time of 00:00:00.

@timronan timronan merged commit a4ee7bd into master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queries for start time 00:00:00 result in miniseed that starts at 23:59:59 the previous day
3 participants