Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Commit

Permalink
Bugfix: (Jazzo) Work Item GH-248 - Excel2007 does not correctly mark …
Browse files Browse the repository at this point in the history
…rows as hidden
  • Loading branch information
Mark Baker committed Dec 30, 2013
1 parent 2bcaa01 commit 8cd6f56
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Classes/PHPExcel/Reader/Excel2007.php
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ public function load($pFilename)

if (isset($xmlSheet->cols) && !$this->_readDataOnly) {
foreach ($xmlSheet->cols->col as $col) {
for ($i = intval($col["min"]) - 1; $i < intval($col["max"]); ++$i) {
for ($i = intval($col["min"]) - 1; $i < intval($col["max"]); ++$i) {
if ($col["style"] && !$this->_readDataOnly) {
$docSheet->getColumnDimension(PHPExcel_Cell::stringFromColumnIndex($i))->setXfIndex(intval($col["style"]));
}
Expand Down Expand Up @@ -2057,9 +2057,9 @@ private static function toCSSArray($style) {

private static function boolean($value = NULL)
{
if (is_numeric($value)) {
if (is_numeric($value) || is_object($value)) {
return (bool) $value;
}
}
return ($value === 'true' || $value === 'TRUE') ? TRUE : FALSE;
}
}
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Fixed in develop branch for release v1.8.0:
- Bugfix: (MBaker) Work Item GH-275 - Insert New Row/Column Before is not correctly updating formula references
- Bugfix: (MBaker) Work Item GH-257 - Passing an array of cells to _generateRow() in the HTML/PDF Writer causes caching problems with last cell in the range
- Bugfix: (MBaker) Work Item GH-193 - Fix to empty worksheet garbage collection when using cell caching
- Bugfix: (Jazzo) Work Item GH-248 - Excel2007 does not correctly mark rows as hidden
- Feature: (amerov) - Implementation of the Excel HLOOKUP() function
- Feature: (MBaker) - Added "Quote Prefix" to style settings (Excel2007 Reader and Writer only)
- Feature: (MBaker) - Added Horizontal FILL alignment for Excel5 and Excel2007 Readers/Writers, and Horizontal DISTRIBUTED alignment for Excel2007 Reader/Writer
Expand Down

0 comments on commit 8cd6f56

Please sign in to comment.