Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Commit

Permalink
Merge pull request #379 from frost-nzcr4/ft-camelcase
Browse files Browse the repository at this point in the history
Change the getter/setter for zeroHeight to camel case
  • Loading branch information
Mark Baker committed Jul 27, 2014
2 parents 2a06bc9 + a6f00db commit 23479fd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions Classes/PHPExcel/Reader/Excel2007.php
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ public function load($pFilename)
$macros = $customUI = NULL;
foreach ($relsWorkbook->Relationship as $ele) {
switch($ele['Type']){
case "http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet":
case "http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet":
$worksheets[(string) $ele["Id"]] = $ele["Target"];
break;
// a vbaProject ? (: some macros)
Expand Down Expand Up @@ -757,7 +757,7 @@ public function load($pFilename)
}
if (isset($xmlSheet->sheetFormatPr['zeroHeight']) &&
((string)$xmlSheet->sheetFormatPr['zeroHeight'] == '1')) {
$docSheet->getDefaultRowDimension()->setzeroHeight(true);
$docSheet->getDefaultRowDimension()->setZeroHeight(true);
}
}

Expand Down Expand Up @@ -1986,7 +1986,7 @@ private function _readRibbon($excel, $customUITarget, $zip)
$nameCustomUI = basename($customUITarget);
// get the xml file (ribbon)
$localRibbon = $this->_getFromZipArchive($zip, $customUITarget);
$customUIImagesNames = array();
$customUIImagesNames = array();
$customUIImagesBinaries = array();
// something like customUI/_rels/customUI.xml.rels
$pathRels = $baseDir . '/_rels/' . $nameCustomUI . '.rels';
Expand Down
4 changes: 2 additions & 2 deletions Classes/PHPExcel/Worksheet/RowDimension.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function setRowHeight($pValue = -1) {
*
* @return bool
*/
public function getzeroHeight() {
public function getZeroHeight() {
return $this->_zeroHeight;
}

Expand All @@ -155,7 +155,7 @@ public function getzeroHeight() {
* @param bool $pValue
* @return PHPExcel_Worksheet_RowDimension
*/
public function setzeroHeight($pValue = false) {
public function setZeroHeight($pValue = false) {
$this->_zeroHeight = $pValue;
return $this;
}
Expand Down
4 changes: 2 additions & 2 deletions Classes/PHPExcel/Writer/Excel2007/Worksheet.php
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ private function _writeSheetFormatPr(PHPExcel_Shared_XMLWriter $objWriter = null
}

// Set Zero Height row
if ((string)$pSheet->getDefaultRowDimension()->getzeroHeight() == '1' ||
strtolower((string)$pSheet->getDefaultRowDimension()->getzeroHeight()) == 'true' ) {
if ((string)$pSheet->getDefaultRowDimension()->getZeroHeight() == '1' ||
strtolower((string)$pSheet->getDefaultRowDimension()->getZeroHeight()) == 'true' ) {
$objWriter->writeAttribute('zeroHeight', '1');
}

Expand Down

0 comments on commit 23479fd

Please sign in to comment.