Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Action: Add steps to test against libxml >= 2.12 #798

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

GH Action: Add steps to test against libxml >= 2.12 #798

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3310914
Run tests against libxml >= 2.12
asispts Jan 25, 2025
bcc81fc
Fix yaml format
asispts Jan 25, 2025
ceb01eb
Remove fail-fast
asispts Jan 27, 2025
b54082e
Install libxml2 via homebrew
asispts Jan 27, 2025
e25ee62
Separate install libxml2 steps
asispts Jan 27, 2025
be3c27f
Fix yaml
asispts Jan 27, 2025
19bf218
Update steps
asispts Jan 27, 2025
0ce96c6
Use double quote
asispts Jan 27, 2025
ad85bfa
Update comment and fix yaml
asispts Jan 28, 2025
1d715e3
Use pre-installed homebrew
asispts Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

# This is a temporary solution.
# Once ubuntu-latest includes libxml2 >= v2.12.0, this step can be removed.
- name: Install latest libxml2 on PHP 8.4 (linux only)
if: ${{ matrix.os == 'ubuntu-latest' && matrix.php == '8.4' }}
run: |
/home/linuxbrew/.linuxbrew/bin/brew install libxml2

Comment on lines +100 to +102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per recent suggestion, let's add the version of this library before & after the install the new version to (a) verify that the install worked as expected, and (b) help us know when the image starts to contain the version that we need.

Suggested change
run: |
/home/linuxbrew/.linuxbrew/bin/brew install libxml2
run: |
php -r 'echo "libxml version: ", LIBXML_DOTTED_VERSION, PHP_EOL;'
/home/linuxbrew/.linuxbrew/bin/brew install libxml2
php -r 'echo "libxml version: ", LIBXML_DOTTED_VERSION, PHP_EOL;'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't work because PHP is not installed yet at this point.

- name: Setup ini config
id: set_ini
shell: bash
Expand Down