Lists::getAssignments(): bug fix for exotic keys #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
utils/lists-getassignments-bug-fix-convoluted-keys
branch
from
e2eefed
to
19a450a
Compare
If function calls or arrays would be used as the _key_ for a list item and the call or array would contain a comma, the return value for the `Lists::getAssignments()` method would be incorrect and would identify more list items than there really are. Fixed now. Includes additional tests.
jrfnl
force-pushed
the
utils/lists-getassignments-bug-fix-convoluted-keys
branch
from
19a450a
to
482d9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If function calls or arrays would be used as the key for a list item and the call or array would contain a comma, the return value for the
Lists::getAssignments()method would be incorrect and would identify more list items than there really are.Fixed now.
Includes additional tests.