Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens\Collections: simplify by implementing a magic __callStatic() method #349

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 15, 2022

Tokens\Collections: internal change

As much as possible, make all methods use (private) properties for the actual token arrays.

Includes fixing up a few references to the ooHierarchyKeywords() method, which should reference the property.

Tokens\Collections: update documentation

Move most pertinent documentation to the properties and remove it from the methods in anticipation of removing most methods in favour of using a __callStatic() magic method.

Includes minor doc fixes.

Tokens\Collections: use magic __callStatic() method

... for all methods without logic and where there has been no name-change between the (now deprecated) property and the replacement method.

Includes simplifying the related tests.

jrfnl added 3 commits October 15, 2022 04:45

Verified

This commit was signed with the committer’s verified signature.
jpkrohling Juraci Paixão Kröhling
As much as possible, make all methods use (`private`) properties for the actual token arrays.

Includes fixing up a few references to the `ooHierarchyKeywords()` method, which should reference the property.
Move most pertinent documentation to the properties and remove it from the methods in anticipation of removing most methods in favour of using a `__callStatic()` magic method.

Includes minor doc fixes.
... for all methods without logic and where there has been no name-change between the (now deprecated) property and the replacement method.

Includes simplifying the related tests.
@jrfnl jrfnl added this to the 1.0.0-alpha4 milestone Oct 15, 2022
@jrfnl jrfnl merged commit 28794c7 into develop Oct 15, 2022
@jrfnl jrfnl deleted the feature/collections-simplify-and-clean-up branch October 15, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant