IsReferenceTest: add extra tests with intersection/DNF types

PHPCSStandards · May 20, 2024 · a631970 · a631970
1 parent e5ac0d2
commit a631970
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 3 deletions.
diff --git a/Tests/BackCompat/BCFile/IsReferenceTest.inc b/Tests/BackCompat/BCFile/IsReferenceTest.inc
@@ -201,6 +201,12 @@ $closure = function &($param) use ($value) {};
 /* testBitwiseAndArrowFunctionInDefault */
 $fn = fn( $one = E_NOTICE & E_STRICT) => 1;
 
+/* testIntersectionIsNotReference */
+function intersect(Foo&Bar $param) {}
+
+/* testDNFTypeIsNotReference */
+$fn = fn((Foo&\Bar)|null /* testParamPassByReference */ &$param) => $param;
+
 /* testTokenizerIssue1284PHPCSlt280A */
 if ($foo) {}
 [&$a, /* testTokenizerIssue1284PHPCSlt280B */ &$b] = $c;

diff --git a/Tests/BackCompat/BCFile/IsReferenceTest.php b/Tests/BackCompat/BCFile/IsReferenceTest.php
@@ -49,16 +49,47 @@ class IsReferenceTest extends UtilityMethodTestCase
     /**
      * Test that false is returned when a non-"bitwise and" token is passed.
      *
+     * @param string            $testMarker   Comment which precedes the test case.
+     * @param array<int|string> $targetTokens Type of tokens to look for.
+     *
+     * @dataProvider dataNotBitwiseAndToken
+     *
      * @return void
      */
-    public function testNotBitwiseAndToken()
+    public function testNotBitwiseAndToken($testMarker, $targetTokens)
     {
-        $testClass = static::TEST_CLASS;
+        $testClass      = static::TEST_CLASS;
+        $targetTokens[] = T_BITWISE_AND;
 
-        $target = $this->getTargetToken('/* testBitwiseAndA */', T_STRING);
+        $target = $this->getTargetToken($testMarker, $targetTokens);
         $this->assertFalse($testClass::isReference(self::$phpcsFile, $target));
     }
 
+    /**
+     * Data provider.
+     *
+     * @see testNotBitwiseAndToken()
+     *
+     * @return array<string, array<string, string|array<int|string>>>
+     */
+    public static function dataNotBitwiseAndToken()
+    {
+        return [
+            'Not ampersand token at all' => [
+                'testMarker'   => '/* testBitwiseAndA */',
+                'targetTokens' => [T_STRING],
+            ],
+            'ampersand in intersection type' => [
+                'testMarker'   => '/* testIntersectionIsNotReference */',
+                'targetTokens' => [T_TYPE_INTERSECTION],
+            ],
+            'ampersand in DNF type' => [
+                'testMarker'   => '/* testDNFTypeIsNotReference */',
+                'targetTokens' => [T_TYPE_INTERSECTION],
+            ],
+        ];
+    }
+
     /**
      * Test correctly identifying whether a "bitwise and" token is a reference or not.
      *
@@ -364,6 +395,10 @@ public static function dataIsReference()
                 'testMarker' => '/* testBitwiseAndArrowFunctionInDefault */',
                 'expected'   => false,
             ],
+            'reference: param pass by ref in arrow function' => [
+                'testMarker' => '/* testParamPassByReference */',
+                'expected'   => true,
+            ],
             'issue-1284-short-list-directly-after-close-curly-control-structure' => [
                 'testMarker' => '/* testTokenizerIssue1284PHPCSlt280A */',
                 'expected'   => true,