Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support the
ServiceControllerServiceProvider
because it decorates the defaultControllerResolver
and callsgetArguments()
on it.This commit also enhances compatibility with Silex by allowing to inject
I didn't remove the injection of the
Request
by parameter name because it would be a BC break. But this is not supported by Silex itself and I assume it was done because it was not really possible to inject it via type hinting using the invoker. So I think we should remove it in a later release (maybe with Silex2 support, which I hope will be released soon after Symfony3).Closes #7