Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ControllerResolver #8

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Conversation

jdreesen
Copy link
Collaborator

@jdreesen jdreesen commented Nov 1, 2015

This is needed to support the ServiceControllerServiceProvider because it decorates the default ControllerResolver and calls getArguments() on it.

This commit also enhances compatibility with Silex by allowing to inject

  • the Application object by type hint
  • the current Request object by type hint

I didn't remove the injection of the Request by parameter name because it would be a BC break. But this is not supported by Silex itself and I assume it was done because it was not really possible to inject it via type hinting using the invoker. So I think we should remove it in a later release (maybe with Silex2 support, which I hope will be released soon after Symfony3).

Closes #7

This is needed to support the ServiceControllerServiceProvider because it decorates the default ControllerResolver and calls getArguments() on it.

This commit also enhances compatibility with Silex by allowing to inject
- the Application object by type hint
- the current Request object by type hint
@mnapoli
Copy link
Member

mnapoli commented Nov 7, 2015

Thanks, sorry for taking so long :)

mnapoli added a commit that referenced this pull request Nov 7, 2015
@mnapoli mnapoli merged commit e0697d0 into PHP-DI:master Nov 7, 2015
@mnapoli
Copy link
Member

mnapoli commented Nov 7, 2015

Released as 1.3.0

@jdreesen jdreesen deleted the issue7-silex1 branch November 8, 2015 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants