feature: BlankLineBetweenImportGroupsFixer - Introduction

[SanderVerkuil]

Closes #4821

I've also updated the PSR12 set to include this rule, to be compliant with the PSR12.

[julienfalque]

Awesome! Just a few nitpicks and this can be merged IMO.

[SanderVerkuil]

@SpacePossum and/or @keradus, sorry for the ping. This is my first pull request to contribute to the amazing PHP CS Fixer, and I was wondering what further needs to be done to get this approved and being used upstream?

[SpacePossum]

The PR already looks great, I left a little review PR on your fork to deal some edge cases where the fixer would break the code, let me know what you think.

[julienfalque]

Hi @SanderVerkuil. Some tests are failing, can you please fix them? Then we can merge :)

[SanderVerkuil]

Hi @SanderVerkuil. Some tests are failing, can you please fix them? Then we can merge :)

Hmn, @SpacePossum added some tests where comments have been added within the use import statement, like:

use Weird\Be/**comment*/hat;

Which is apparently correct php in some cases, but not all.

The errors are regarding PHP syntax errors, and used to run fine on PHP 7 if I recall correctly, but apparently break on PHP 8.1. Should I just remove those test cases (as the error is that it's a PHP syntax error), or only test these cases in PHP 7?

[julienfalque]

Not sure this test has much value if it is only valid on a PHP version that we'll likely stop supporting soon anyway. I would remove it. What do you think @SpacePossum?

[SpacePossum]

The failure on 7.4 are a priority test/fixture issue in here:

https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/6761749e9c651f15ae58e42cd82c76cbb61fdf00/tests/Fixtures/Integration/priority/ordered_imports%2Cblank_line_between_import_groups.test#L26

So lets see what is up with that.

Than lets move the use Weird\Be/**comment*/hat; to a dedicated test method

    /**
     * @requires PHP <8.0
     */

, as I don't know what the planning is for dropping 7.4 support but my guess is it might be for a while

[SpacePossum]

please consider: SanderVerkuil#2
if happy please merge, than rebase and squash this PR into one commit with only you as author,
please update the title of the PR to start with feature:
thanks!

[SanderVerkuil]

@SpacePossum Will do that as soon as I'm home tomorrow 💪. Thanks for your help and support! Now only another approval for the tests and I'll happily squash all commits

[coveralls]

Coverage increased (+0.006%) to 92.879% when pulling 36c2d6b on SanderVerkuil:fix/issue-4821/blank-line-between-import-groups into 7936fb2 on FriendsOfPHP:master.

[SanderVerkuil]

@SpacePossum The commits have been rebased and squashed, and is now a single commit. Thanks for all the help, let's hope this will be merged soon 🤞

[SpacePossum]

Thanks! : D Hope it will ship soon as well :)

[julienfalque]

Thank you @SanderVerkuil.