Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IndexNotFoundException (BC Break) #470

Draft
wants to merge 6 commits into
base: 0.6
Choose a base branch
from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Dec 27, 2024

This PR should let us check if all search engines throw a not found exception which we may can catch and rethrow our own exception to maybe build up a auto setup in future (see #463).

BC Breaks

New recommended way to setup Elasticsearch and Opensearch is to disable auto create of indexes, this avoids that a false Schema of your index is created in any case:

services:
  elasticsearch:
    image: # ...
    environment:
      # ...
+     action.auto_create_index: 'false'
    # ...

Existing clusters can be updated with:

curl -X PUT "http://localhost:9200/_cluster/settings" \
-H "Content-Type: application/json" \
-d '{
  "persistent": {
    "action.auto_create_index": "false"
  }
}'

Todo

  • ⚪ Memory (custom handeled)
  • ⚪ Loupe (custom handeled / by default autocreated with custom settings)
  • ⚠️ Elasticsearch (only with custom setting we get error or 404 else autocreated with basic engine specific settings)
  • ⚠️ Opensearch (not tested but think same as Elasticsearch)
  • ❌ Algolia (no error thrown - autocreated with basic engine specific settings)
  • ❌ Meilisearch (no error thrown - autocreated with basic engine specific settings)
  • ❌ Redisearch (no error thrown - document created but Index not as 2 JSON.SET and FT are two different modules)
  • ⚪ Solr (throws 404)
  • ⚪ Typesense (throws a NotFoundObject exception)

@alexander-schranz alexander-schranz added features New feature or request Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue Adapter: Memory Memory Adapter related issue Adapter: ReadWrite ReadWrite Adapter related issue Adapter: Multi Multi Adapter related issue Adapter: Meilisearch Meilisearch Adapter related issue Adapter: Algolia Algolia Adapter related issue Adapter: Solr Solr Adapter related issue Adapter: Typesense Typesense Adapter related issue Adapter: RediSearch RediSearch Adapter related issue Adapter: Loupe Loupe Adapter related issue labels Dec 27, 2024
@alexander-schranz alexander-schranz changed the title Introduce IndexNotFoundException Introduce IndexNotFoundException (BC Break) Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adapter: Algolia Algolia Adapter related issue Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Loupe Loupe Adapter related issue Adapter: Meilisearch Meilisearch Adapter related issue Adapter: Memory Memory Adapter related issue Adapter: Multi Multi Adapter related issue Adapter: Opensearch Opensearch Adapter related issue Adapter: ReadWrite ReadWrite Adapter related issue Adapter: RediSearch RediSearch Adapter related issue Adapter: Solr Solr Adapter related issue Adapter: Typesense Typesense Adapter related issue features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant