Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canary test record sets #81

Merged
merged 9 commits into from
Jun 11, 2024
Merged

Conversation

vedantthapa
Copy link
Collaborator

  • Add minimal permissions for SA to manage ip address. I've granted the Compute Public IP Admin role
    This is done to avoid hard-coding an IP address into the rrdatas field
  • Add ComputeAddress resource
  • Add DNSRecordSet resources for each domain that we control

@vedantthapa
Copy link
Collaborator Author

vedantthapa commented Jun 11, 2024

Since these resources are breaking our validation jobs, I'm going to move them inside ./k8s/components/infrastructure. These definitions have a slightly different schema since they use rrdatasRefs instead of rrdatas so the validate-mandatory-fields action will always fail.

Given that these resources not necessarily end-user related and more for internal testing, I hope we're cool with this.

Copy link
Collaborator

@ericmalen ericmalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedantthapa vedantthapa merged commit 320b9ec into main Jun 11, 2024
1 check passed
@vedantthapa vedantthapa deleted the add-canary-test-record-sets branch June 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants