Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and remove deletion-policy #77

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Cleanup and remove deletion-policy #77

merged 5 commits into from
Jun 6, 2024

Conversation

vedantthapa
Copy link
Collaborator

  • Remove deletion-policy annotation from resources
  • Remove root-sync.yaml since we switched to Flux with New autopilot cluster no anthos #73
  • Add the following admonition for bilingual domain issue -

    Due an upstream issue, none of the subdomains on phac-aspc.gc.ca will resolve correctly in the PHAC office network. If you have users accessing your service from an on-prem environment, we recommend that you consider using one of the unilingual domains.

    This admonition will be removed once the issue is fixed.

Copy link
Collaborator

@ericmalen ericmalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@tcaky tcaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedantthapa vedantthapa merged commit 5ea194c into main Jun 6, 2024
3 of 5 checks passed
@vedantthapa vedantthapa deleted the cleanup branch June 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants